Remove bare value handling for perspective utilities#13288
Merged
RobinMalfait merged 3 commits intonextfrom Mar 20, 2024
Merged
Remove bare value handling for perspective utilities#13288RobinMalfait merged 3 commits intonextfrom
RobinMalfait merged 3 commits intonextfrom
Conversation
Comment on lines
-3145
to
-3148
| .perspective-123 { | ||
| perspective: 123px; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think we should move the perspective-123 example to the expect below where we explicitly test that it doesn't generate anything.
This is now moved to the spot where we ensure that nothing is generated at all. This prevents us from accidentally updating a snapshot and missing a potential bug.
RobinMalfait
approved these changes
Mar 20, 2024
KrisBraun
approved these changes
Mar 20, 2024
thecrypticace
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes bare value handling from the perspective utilities, so that utilities like
perspective-300will no longer generate declarations likeperspective: 300px.Generally we support bare values as a way to avoid putting things into the default theme, and since the perspective utilities already have a named scale in the theme I don't think it makes sense to support bare values. Bare values should be thought of as real API that we would include in the IntelliSense completions list when someone is typing a utility, and I don't think we want to include any numeric values in that list for
perspective👍